Exit MarkBind with nonzero exit code on fatal error#679
Merged
Conversation
Member
|
@Xenonym need you to resolve conflicts. |
Contributor
Author
|
@yamgent merge conflicts resolved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Resolves #651.
What is the rationale for this request?
MarkBind should exit with a nonzero return code (eg.
1) to indicate an error condition. This is especially important for running MarkBind in an automated context where other programs or scripts are relying on the exit code of MarkBind to detect errors (eg. as part of a custom build script, or Travis CI automation).What changes did you make? (Give an overview)
I created a common error handler
handleErrorto both log an error and setprocess.exitCode = 1, ensuring that MarkBind exits with a nonzero exit code on error.Testing instructions:
markbind buildon a directory without asite.json). MarkBind should exit with a nonzero exit code.echo $?$LASTEXITCODE